fix: re-enable code challenge support #1035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdonnalley
approved these changes
Mar 11, 2024
|
QA
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
CLI auth should default to using code challenges and code verifiers for PKCE. This used to be the case but somehow it was disabled. This adds it back and also adds unit tests to ensure it stays that way.
What issues does this PR fix or reference?
@W-15198289@
QA:
All auth that happens as part of NUTs will verify that it doesn't break anything. To ensure that it works with an org that has PKCE set, open your org, to to setup, search for "oauth", click on "OAuth and OpenID Connect Settings", toggle the "Require Proof Key for Code Exchange (PKCE) Extension" on. Then do
sf org login webtargeting that org.